Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenges using babel.config.js directly #418

Open
chriskrycho opened this issue Oct 26, 2021 · 1 comment
Open

Challenges using babel.config.js directly #418

chriskrycho opened this issue Oct 26, 2021 · 1 comment

Comments

@chriskrycho
Copy link
Contributor

In ember-modifier, I attempted to use babel.config.js directly, in concert with the new buildEmberPlugins API. However, this has a problem in that @babel/preset-env requires targets to be set, and while it makes sense for addons to supply their own config, they should not be supplying their own targets: the host should always be in control of the targets it uses to build. Additionally, this raises the question of whether all addons should be installing their own copies of @babel/preset-env to make this work (presumably yes? But there's then a further degree of explicit ecosystem coordination required for upgrades). Net, we need further design work here.

(Prompted by a conversation with @rwjblue where he explained all of this to me. 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants