Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

ember template-lint:print-failing Does Not Work for Addons #381

Open
jherdman opened this issue Sep 11, 2018 · 3 comments
Open

ember template-lint:print-failing Does Not Work for Addons #381

jherdman opened this issue Sep 11, 2018 · 3 comments
Labels

Comments

@jherdman
Copy link

jherdman commented Sep 11, 2018

I have a "mega component" that lives in an addon. It, of course, has a lot of template lint violations, and some that I'd prefer to deal with slowly. The current output for the ...print-failing command is:

pending: []

But yarn run lint:hbs indicates 300+ problems.

I'm using the 1.0.0.beta-2 at the moment.

@rwjblue
Copy link
Member

rwjblue commented Sep 11, 2018

The print-failing command is currently hard coded to run against the app directory, and since this is in addon it doesn't see any of the issues.

We should:

  • Make it auto-detect the type of project, and when in an addon use addon and otherwise use app
  • Add path as a command option so that you can run it on only specific paths

I would love help to push this forward...

@rwjblue rwjblue added the bug label Sep 11, 2018
@jherdman
Copy link
Author

I should have some bandwidth to look into this this week.

@rwjblue
Copy link
Member

rwjblue commented Sep 12, 2018

Awesome!

jherdman added a commit to jherdman/ember-cli-template-lint that referenced this issue Sep 13, 2018
jherdman added a commit to jherdman/ember-cli-template-lint that referenced this issue Sep 13, 2018
jherdman added a commit to jherdman/ember-cli-template-lint that referenced this issue Sep 13, 2018
jherdman added a commit to jherdman/ember-cli-template-lint that referenced this issue Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants