Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFORMATION] Does any stage of ember-modifier lifecycle that runs on server side with Fastboot? #88

Open
rogeraraujo90 opened this issue May 25, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@rogeraraujo90
Copy link

I was asked in my project and I couldn't find a straight answer in the documentation. As I understand, projects that uses Fastboot doesn't need to be worried about add any check if the modifier code is running in Fastboot. Is this right?

@pzuraq
Copy link
Contributor

pzuraq commented May 26, 2021

Modifiers do not run in Fastboot at all, correct. This is noted in the official guides on modifiers, in the Tomster says bubble, but it might be good to mention it again in the docs here to make that clear since that can be hard to find.

@rogeraraujo90
Copy link
Author

Thank you @pzuraq . And yes, I think is a good idea put this information about Fastboot in the docs too! (let me know if I can open a small PR to contributing 😄)

@rwjblue
Copy link
Member

rwjblue commented May 26, 2021

Sounds great! PR absolutely would be welcome

@chriskrycho chriskrycho added the documentation Improvements or additions to documentation label Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants