Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eager option for functional modifiers is undocumented outside migration guide #774

Open
elwayman02 opened this issue May 15, 2023 · 2 comments

Comments

@elwayman02
Copy link
Contributor

The v4 Migration guide mentions that all function-based modifiers must add { eager: false } to migrate to v4. However, there is no mention of function-based modifiers having an options hash in the README for v3 or v4, making this an undocumented feature. If functional modifiers are expected to pass this option in v4, it should be documented as part of the core API in the README, not just in the migration guide.

@fairnightzz
Copy link

I agree with this as well ^

@didoo
Copy link

didoo commented Jun 3, 2024

+1 on this, expecially in the context of Typescript (I had to add a @ts-ignore to prevent TS to complain about this extra argument). Should the signature for the modifiers be updated to include this extra option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants