Get tests passing again by testing against ember-data@3.8.0 instead of master #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json will reference the modules in the lib directory
mansona
moved this from In progress
to Existing PRs to Review
in Fixing Testing Infrastructure
|
Pushed a commit to use the newly released version of ember-cli-addon-tests (0.11.1). |
Fixing Testing Infrastructure
automation
moved this from Existing PRs to Review
to Done
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomdale/ember-cli-addon-tests#208
ember-cli-addon-test by default tests against ember-data#master this PR removes #master and uses ^3.8.0
adds node 10 to the test metrics
uses npm 6 or greater