Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embroider] Fastboot enabled apps might fail under embroider-optimized #924

Closed
BobrImperator opened this issue Aug 18, 2023 · 1 comment · Fixed by #939
Closed

[Embroider] Fastboot enabled apps might fail under embroider-optimized #924

BobrImperator opened this issue Aug 18, 2023 · 1 comment · Fixed by #939

Comments

@BobrImperator
Copy link

BobrImperator commented Aug 18, 2023

Encountered while working on ember-simple-auth. ESA test-suite tests some basic scenarios with fastboot in one of the test apps.
embroider-optimized scenario fails. See Embroider Optimized Test Scenario

The error points to this file:
https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/packages/ember-cli-fastboot/vendor/experimental-render-mode-rehydrate.js#L4

ReferenceError: Ember is not defined
    <anonymous> experimental-render-mode-rehydrate.js:4
    <anonymous> experimental-render-mode-rehydrate.js:33

image

embroider-safe scenario works just fine.

mainmatter/ember-simple-auth#2633 (comment)

@villander
Copy link
Contributor

I have the same error using the following packages

 "@embroider/compat": "^3.4.5",
 "@embroider/core": "^3.4.5",
 "@embroider/webpack": "^3.2.2",
 "ember-cli-fastboot": "^4.1.2",

cc @mansona

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants