Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastBootAppServer duplicates response headers #884

Open
ghost opened this issue Jan 13, 2022 · 0 comments
Open

FastBootAppServer duplicates response headers #884

ghost opened this issue Jan 13, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Jan 13, 2022

FastBootAppServer duplicates response headers which were set by middleware registered in beforeMiddleware hook.

issue-screenshot

I've found that it happens during fastboot-express-middleware execution, here:
https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/packages/fastboot-express-middleware/src/index.js
lines: 44-46

From my perspective, the problem is that code doesn't check already existing response headers before adding new headers from result.headers.

Here, you can find a prepared by me demo of the issue:
https://github.com/yevhenii-pinkal/fastboot-duplicates-headers-issue/tree/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants