Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why some tests need application-template-wrapper enabled to pass #838

Open
mansona opened this issue Jun 21, 2021 · 0 comments
Open

Comments

@mansona
Copy link
Member

mansona commented Jun 21, 2021

As part of my work to upgrade ember-cli-fastboot using ember-cli-update I noticed that some tests failed because they needed the application-template-wrapper to be enabled in optitonal-features.

I didn't really have the time to investigate why, and I didn't want to block the other PR any more than it already was 🙈 so this issue is to keep track that it needs to be looked into.

To test this, just undo the work in this commit and see why some tests fail 🤷 I have a feeling it could just be a selector depending on the wrapper div existing 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants