Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content not replaced/hydrated when using Embroider #785

Open
josemarluedke opened this issue Sep 6, 2020 · 7 comments
Open

Content not replaced/hydrated when using Embroider #785

josemarluedke opened this issue Sep 6, 2020 · 7 comments

Comments

@josemarluedke
Copy link
Contributor

Adding Embroider to a FastBoot site causes the content to not be cleared, instead the content is rendered twice.

The issue can be seen in this PR.

Note, I have EXPERIMENTAL_RENDER_MODE_SERIALIZE enabled, but it does not affect the bug if I disable that.

@kiwiupover
Copy link
Member

@josemarluedke I got your PR running and every seems fine to me.

Why do you think it is rendering the content twice?

@kiwiupover
Copy link
Member

@josemarluedke ping are you stilling having issues here?

@josemarluedke
Copy link
Contributor Author

Yes, I'm still having this issue. It's weird you were not able to see in that PR. The entire site is rendered twice. I can post a screenshot when I am back to the computer.

@kiwiupover
Copy link
Member

What do you mean by rendered twice?

@josemarluedke
Copy link
Contributor Author

Here is an image showing that the HTML generated in FastBoot was not removed when the client version executed, the client version just prepended the content, leaving the HTML from the FastBoot and adding the HTML for the client. That makes it show the entire site twice on the same page.

Screen Shot 2020-10-02 at 8 40 27 AM

@kiwiupover
Copy link
Member

Interesting. I will have a further look in the next few days.

@rahulk94
Copy link
Contributor

rahulk94 commented Nov 8, 2021

@kiwiupover @josemarluedke did anything ever come out of this investigation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants