Embroider Support: Moved app factory module out of fastboot-app-module #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue @stefanpenner Created this PR to clean up fastboot-app-module code that gets inserted as part of app.js. I made changes to move the app-factory to a separate module and created a broccoli plugin to generate the content and merged as part of |
dnalagatla
force-pushed
the
dnalagatla/move-appFactory-module-to-fastboot-tree
branch
from
a0f09f3
to
c2f3c9c
Compare
dnalagatla
force-pushed
the
dnalagatla/move-appFactory-module-to-fastboot-tree
branch
2 times, most recently
from
d0fbb39
to
7c861dd
Compare
* Cleaned up fastboot-app-module. * Used broccoli-file-creator to insert app factory module as part of <app>-fastboot.js * This clean up ensures fastboot specific App-factory code is not shipped to browsers.
dnalagatla
force-pushed
the
dnalagatla/move-appFactory-module-to-fastboot-tree
branch
from
7c861dd
to
617a17c
Compare
rwjblue
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app-boottype contentFor, this change ensures the insertion of the app-factory module is not dependent onapp-bootstep in the build process.WIP: #700