Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this supposed to work in addons? #274

Open
mansona opened this issue Mar 26, 2020 · 1 comment
Open

Is this supposed to work in addons? #274

mansona opened this issue Mar 26, 2020 · 1 comment

Comments

@mansona
Copy link
Member

mansona commented Mar 26, 2020

I just ran this in an addon but it didn't convert any of the templates in addon/components/ 馃

My question is:
a) does it work with addons? and
b) does it work with co-located components (in an addon)?

Edit: it might have been worth mentioning that I'm using ember-cli-update to run this. I looked at the readme and it seems like we are able to tell the codemod to find the files and I wonder if this is actually a bug in ember-cli-update rather than this codemod 馃

@rajasegar
Copy link
Member

@mansona Yes it will work on addons if you point at the right folder like directly using the codemod

npx ember-angle-brackets-codemod@2  addon/templates

I am using the version 2 here, since there was no telemetry at that point, I am not sure how the current command syntax mentioned in README works for addons with telemetry
But with ember-cli-update there is an issue I guess here
https://github.com/ember-cli/ember-cli-update-codemods-manifest/blob/db56d248fdb23a43226cad7fede7113e5c511dff/packages/addon/manifest.json#L87

ember-angle-brackets-codemod@2 angle-brackets ./app/templates

As you can see we are deliberately using the version 2 with folder app/templates but I guess most of the time templates will be in addon/templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants