Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to run offline (not using puppeteer / dev server)? #242

Open
jacobq opened this issue Feb 13, 2020 · 6 comments
Open

Possible to run offline (not using puppeteer / dev server)? #242

jacobq opened this issue Feb 13, 2020 · 6 comments

Comments

@jacobq
Copy link

jacobq commented Feb 13, 2020

I would like to run this codemod on an ember-electron app, but it currently won't run properly via ember s since it relies on requireNode in some places. Other codemods that I've used seemed to operate solely on the source files, which hasn't been a problem. Is the only way that I can use this codemod to first modify my app such that it will gracefully handle running outside of the electron context?

Related: #217 #200

Maybe also something like this could help? https://github.com/nondanee/puppeteer-electron

@jacobq jacobq changed the title Possible to run offline (not using dev server)? Possible to run offline (not using puppeteer / dev server)? Feb 13, 2020
@tylerturdenpants
Copy link
Collaborator

version 2 can be used to run offline. It uses a best guess strategy so there might be some conversion errors

@jacobq
Copy link
Author

jacobq commented Feb 13, 2020

version 2 can be used to run offline. It uses a best guess strategy so there might be some conversion errors

Ah, perfect, thank you. I think that will be good enough for me as I don't mind giving the mod some hints and doing a few manual corrections myself.

Is there some documentation that describes why the live server is needed / how it is able to do a better job than, say, version 2?

@RobbieTheWagner
Copy link

@jacobq did you ever figure this out? I'm hitting errors with puppeteer.

@jacobq
Copy link
Author

jacobq commented May 6, 2020

@jacobq did you ever figure this out? I'm hitting errors with puppeteer.

IIRC I just used the old version (which doesn't use puppeteer).

@rajasegar
Copy link
Member

@rwwagner90 Can you try this now, since we have made telemetry optional

npx github:ember-codemods/ember-angle-brackets-codemod --no-telemetry ./my-path

@RobbieTheWagner
Copy link

@rajasegar you have to pass --no-telemetry? I tried omitting --telemetry as the docs suggested. If we have to manually pass --no-telemetry we should probably document that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants