From 9444d56f06cf9f843e1eaf69e6da726eaf238833 Mon Sep 17 00:00:00 2001 From: Alon Bukai Date: Mon, 4 Feb 2019 17:04:07 +0200 Subject: [PATCH 1/3] fix: no-deeply-nested-...-each examples --- docs/rules/no-deeply-nested-dependent-keys-with-each.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/rules/no-deeply-nested-dependent-keys-with-each.md b/docs/rules/no-deeply-nested-dependent-keys-with-each.md index c73f2d594e..b13d3bb955 100644 --- a/docs/rules/no-deeply-nested-dependent-keys-with-each.md +++ b/docs/rules/no-deeply-nested-dependent-keys-with-each.md @@ -2,7 +2,7 @@ For performance / complexity reasons, Ember does not allow deeply-nested computed property dependent keys with `@each`. At runtime, it will show a warning about this: -> WARNING: Dependent keys containing @each only work one level deep. You used the key "foo.@each.bar.baz" which is invalid. Please create an intermediary computed property. +> WARNING: Dependent keys containing @each only work one level deep. You used the key `"foo.@each.bar.baz"` which is invalid. Please create an intermediary computed property. ## Rule Details @@ -18,11 +18,11 @@ Examples of **correct** code for this rule: ```js displayNames: computed('owners.@each.name', function() { - return this.owners.mapBy(owners, 'name'); + return this.owners.mapBy('owner', 'name'); }), owners: computed('todos.@each.owner', function() { - return this.todos.mapBy(todo, 'owner'); + return this.todos.mapBy('todo', 'owner'); }) ``` From b99c41018050e5eb9f363e3eb3e6088ca85a36e3 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Tue, 5 Feb 2019 18:49:39 +0200 Subject: [PATCH 2/3] Update docs/rules/no-deeply-nested-dependent-keys-with-each.md Co-Authored-By: Alonski --- docs/rules/no-deeply-nested-dependent-keys-with-each.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rules/no-deeply-nested-dependent-keys-with-each.md b/docs/rules/no-deeply-nested-dependent-keys-with-each.md index b13d3bb955..7ab7c5d994 100644 --- a/docs/rules/no-deeply-nested-dependent-keys-with-each.md +++ b/docs/rules/no-deeply-nested-dependent-keys-with-each.md @@ -22,7 +22,7 @@ displayNames: computed('owners.@each.name', function() { }), owners: computed('todos.@each.owner', function() { - return this.todos.mapBy('todo', 'owner'); + return this.todos.mapBy('owner'); }) ``` From ecfc5a272016880a56d8a2c23d62ea002e0f1663 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Wed, 6 Feb 2019 11:38:00 +0200 Subject: [PATCH 3/3] Update docs/rules/no-deeply-nested-dependent-keys-with-each.md Co-Authored-By: Alonski --- docs/rules/no-deeply-nested-dependent-keys-with-each.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/rules/no-deeply-nested-dependent-keys-with-each.md b/docs/rules/no-deeply-nested-dependent-keys-with-each.md index 7ab7c5d994..3876cdbcee 100644 --- a/docs/rules/no-deeply-nested-dependent-keys-with-each.md +++ b/docs/rules/no-deeply-nested-dependent-keys-with-each.md @@ -18,7 +18,7 @@ Examples of **correct** code for this rule: ```js displayNames: computed('owners.@each.name', function() { - return this.owners.mapBy('owner', 'name'); + return this.owners.mapBy('name'); }), owners: computed('todos.@each.owner', function() {