Add useOptionalChaining option (default false) to no-get rule
#845
+159
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongoose700
approved these changes
Jun 14, 2020
lib/rules/no-get.js
Outdated
| `this.${property}`, | ||
| useOptionalChaining ? `this.${property.replace(/\./g, '?.')}` : undefined, | ||
| ] | ||
| .filter((item) => Boolean(item)) |
There was a problem hiding this comment.
nit: .filter(Boolean)
lib/rules/no-get.js
Outdated
| return isImportedGet | ||
| ? `Use \`this.${property}\` instead of \`get(this, '${property}')\`` | ||
| : `Use \`this.${property}\` instead of \`this.get('${property}')\``; | ||
| function makeErrorMessageForGet(property, isImportedGet, useOptionalChaining) { |
There was a problem hiding this comment.
Could you change this to makeErrorMessageForGet(property, { isImportedGet, useOptionalChaining })? Passing in multiple unnamed boolean parameters can become tricky.
lib/rules/no-get.js
Outdated
| // Not safe to autofix nested properties because some properties in the path might be null. | ||
| return null; | ||
| } | ||
|
|
||
| if (!isValidJSVariableName(path)) { | ||
| if (!isValidJSPath(path)) { | ||
| // Do not autofix since the path would not be a valid JS variable name. |
There was a problem hiding this comment.
This comment should also replace variable name with path.
lib/rules/no-get.js
Outdated
| fix(fixer) { | ||
| if (path.includes('.')) { | ||
| if (path.includes('.') && !useOptionalChaining) { |
There was a problem hiding this comment.
This fix for both paths seems to be identical. Should it be extracted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we cannot autofix usages with nested paths, but we can with this new option enabled.
Before autofix:
After autofix:
Fixes #843.
CC: @fivetanley @mongoose700