Add eslint-plugin-jest internally and enable rules #625
+268
−179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Dec 12, 2019
| @@ -11,7 +11,7 @@ const RuleTester = require('eslint').RuleTester; | |||
|
|
|||
| describe('imports', () => { | |||
| it('should expose the default ignored properties', () => { | |||
| expect(rule.DEFAULT_IGNORED_PROPERTIES).toEqual([ | |||
| expect(rule.DEFAULT_IGNORED_PROPERTIES).toStrictEqual([ | |||
There was a problem hiding this comment.
what's the reason to use Strict here?
There was a problem hiding this comment.
Prefer the more strict assertion when possible.
https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-strict-equal.md
There was a problem hiding this comment.
hmm, that seems irrelevant to me in this case though 🤔
There was a problem hiding this comment.
Yeah in this case it doesn't matter but it's still valuable to encourage stricter assertions in general.
.eslintrc.js
Outdated
| @@ -18,6 +19,7 @@ module.exports = { | |||
| 'eslint:recommended', | |||
| 'plugin:eslint-comments/recommended', | |||
| 'plugin:eslint-plugin/all', | |||
| 'plugin:jest/all', | |||
There was a problem hiding this comment.
are we sure we want all rules instead of recommended?
There was a problem hiding this comment.
Switched to enabling the recommended and style configurations plus ~15 optional rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/jest-community/eslint-plugin-jest
@Turbo87 this may interest you.