Add new rule no-deprecated-router-transition-methods
#1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lin-ll
changed the title
no-deprecated-router-transition-methods
lin-ll
reviewed
Dec 22, 2022
lin-ll
reviewed
Dec 23, 2022
bmish
reviewed
Dec 27, 2022
rtablada
requested review from
lin-ll and
bmish
and removed request for
lin-ll
|
I've updated the tests to have some examples of multiple classes (and fixes), updated the readme as requested, and have made changes to the error message to use |
|
LGTM - but looks like some tests / lint errors are still failing |
lin-ll
approved these changes
Dec 29, 2022
bmish
requested changes
Dec 29, 2022
bmish
reviewed
Dec 29, 2022
rtablada
force-pushed
the
rt/no-deprecated-router-transition-methods
branch
from
75faccf
to
746dec3
Compare
rtablada
force-pushed
the
rt/no-deprecated-router-transition-methods
branch
from
746dec3
to
211f50e
Compare
|
Updated this PR with requested feedback and learnings from the Added nested class tests, class expression tests, and accounted for legacy |
bmish
changed the title
no-deprecated-router-transition-methodsno-deprecated-router-transition-methods
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1714 this implements a lint rule to detect and fix errors associated with the
routing.transition-methodsdeprecation.This closes #1074