-
-
Notifications
You must be signed in to change notification settings - Fork 197
/
no-unnecessary-service-injection-argument.js
46 lines (40 loc) · 1.24 KB
/
no-unnecessary-service-injection-argument.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
'use strict';
const utils = require('../utils/utils');
const emberUtils = require('../utils/ember');
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
const ERROR_MESSAGE = "Don't specify injected service name as an argument when it matches the property name.";
module.exports = {
meta: {
docs: {
description: 'Disallow unnecessary argument when injecting service',
category: 'Best Practices',
recommended: false
},
fixable: 'code',
ERROR_MESSAGE
},
create(context) {
return {
Property(node) {
if (!emberUtils.isInjectedServiceProp(node.value) ||
node.value.arguments.length !== 1 ||
!utils.isLiteral(node.value.arguments[0])) {
return;
}
const keyName = node.key.name;
const firstArgValue = node.value.arguments[0].value;
if (keyName === firstArgValue) {
context.report({
node: node.value.arguments[0],
message: ERROR_MESSAGE,
fix(fixer) {
return fixer.remove(node.value.arguments[0]);
}
});
}
}
};
}
};