Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module-unification - look in src/init #45

Closed
wants to merge 1 commit into from

Conversation

iezer
Copy link

@iezer iezer commented Jul 7, 2017

@mixonic This changes makes an Ember app lookup initializers in src/init. The exported function loadInitializers is called from app code in src/main.js so we could also change the input there to have the right prefix. A few questions:

  • What's the best way to have the flag set from the ember feature flag?
  • Many apps like the travis app will have addons that add initializers to the app tree. So what we really want, instead of this change, is to call loadInitializers twice from the src/main.js, for example:
loadInitializers(App, config.modulePrefix);
loadInitializers(App, config.modulePrefix + '/src/init');

Another solution is to use both prefixes within this addon so that we can call loadInitializers once in the app code.

Call to loadInitializers in partial-app

Fixes #42

@mixonic
Copy link
Member

mixonic commented Jul 7, 2017

I'd like to fix this in the app blueprint: emberjs/ember-module-unification-blueprint#4 or generally via documentation.

@mixonic mixonic closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Unification RFC support
2 participants