New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript support #111
Conversation
I'd rather convert to TS than add untested types 🤔 |
ok, I'll try to do it |
would ec-typescript be ok here? |
@rwjblue are there any issues blocking this PR from being merged? I can fix conflicts if this PR looks good enough to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this PR 😢
Overall, I'm 👍 just left a few small inline comments/tweaks
I'd prefer this one |
also needs a rebase |
f3dc9be
to
0c7aeb6
Compare
Any update on this? |
@msalahz I've been busy a bit with some other activity last months. Going to update this PR today or this weekend. |
rebased the branch. There is a test failure for ember-beta scenario
tried it locally, but can't reproduce. I think it might be phantom or unrelated to the PR. Maybe restart can help |
ya, test failure has to be fixed with ember-source@v3.13.0-beta.3 emberjs/ember-test-helpers#694 (comment) |
Rebased again and tests 🍏 . @rwjblue is there something needed to be done to ship this PR? |
I've noticed in the new ember app, import statement for this addon is highlighted with an error in the app.ts. I think it makes sense to provide basic types by default.
I'm wondering which would be the best TS support strategy for a small addon like that, which successfully lived for yers w/o any worries about TS.
Should we:
.d.ts
file and cover withdtslint
testsd.ts
to DefinitelyTyped