Change option names (module-path-filter and test-file-path-filter) and Enable to execute unique test modules after filtering #300
+90
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Option names, from module-path-filter to module-path and from test-file-path-filter to file-path. 2. to enable to have unique test modules to run after filtering. e.g. when options are repeated it only runs one
choheekim
changed the title
stefanpenner
approved these changes
Jun 18, 2019
| @@ -48,8 +48,8 @@ export default class EmberExamMochaTestLoader extends TestLoader { | |||
| * Loads the test modules depending on the urlParam | |||
| */ | |||
| loadModules() { | |||
| const modulePathFilter = this._urlParams.get('modulePathFilter'); | |||
| const testFilePathFilter = this._urlParams.get('testFilePathFilter'); | |||
| const modulePath = this._urlParams.get('modulePath'); | |||
There was a problem hiding this comment.
is this a breaking change?
There was a problem hiding this comment.
We never released the previous PR into a version. So would that still be consider breaking?
There was a problem hiding this comment.
ah, nope then no breaking change.
| @@ -55,8 +55,8 @@ export default class EmberExamQUnitTestLoader extends TestLoader { | |||
| loadModules() { | |||
| const loadBalance = this._urlParams.get('loadBalance'); | |||
| const browserId = this._urlParams.get('browser'); | |||
| const modulePathFilter = this._urlParams.get('modulePathFilter'); | |||
| const testFilePathFilter = this._urlParams.get('testFilePathFilter'); | |||
| const modulePath = this._urlParams.get('modulePath'); | |||
|
|
|
Looks good to me! |
|
@step2yeung @stefanpenner As you all approve it’s good to go! Thank you all for the quick reviewing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. ember exam --file-path='foo/tests/unit/foo.js, /tests/unit/foo.js'
it executes
foo/tests/unit/foo.jsfile once