Ignore default folder name used by broccoli-debug #9680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmessenger
changed the title
|
This seems great, can you confirm that this also ends up in the addon blueprint? |
|
@notmessenger poke! |
@locks have pushed changes |
|
Thanks! I've approved CI and enabled auto-merge. |
|
I don't think This means that files and folders like This will also affect all addons that update to v4.3 using |
This was referenced Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cli.emberjs.com/release/advanced-use/debugging/#logging talks about how debugging is ready to be used and only an environment variable needs to be set to use it. When a user does so though a
/DEBUGfolder is created, which they then need to ensure does not get checked into their repo.Keeping this from being checked in can certainly fall within the realm of the end-application's responsibility, as a user should know how to a manage such resources, etc, but I am of the opinion that this folder falls in the same category as other files and paths already being ignored via the .gitignore file, as they are by-products of running commands provided by the Ember CLI ecosystem and not something the user is necessarily aware they are opting into to when running the command.