Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to TS or supply ambient definitions #9996

Open
chriskrycho opened this issue Aug 30, 2022 · 3 comments
Open

Convert to TS or supply ambient definitions #9996

chriskrycho opened this issue Aug 30, 2022 · 3 comments

Comments

@chriskrycho
Copy link
Contributor

As part of Ember.js RFC #0800, this package needs to supply type definitions. Preferably, this would happen by converting to TS and generating from the source; as an alternative, it can publish ambient types (presumably starting with the ones on DefinitelyTyped).

All the members of the Typed Ember team are happy to advise on how to do this; feel free to reach out in #dev-typescript on Discord if you have questions!

@locks
Copy link
Contributor

locks commented Sep 15, 2022

Katie, Kelly and I briefly discussed this during the weekly CLI call and the general opinion is that people with more context of the implications and current active contributors should drive the decision.
@rwjblue @ef4 @bertdeblock what do you think is the best plan going forward?

@ef4
Copy link
Contributor

ef4 commented Sep 15, 2022

We have the start of types here because Embroider needed them. They weren't intended to be complete, just enough API to do what Embroider needed to do.

@gitKrystan
Copy link

gitKrystan commented Jan 9, 2023

I did a quick spike on what actual TS conversion would take, and it looks like it would be quite a project because many of the libraries this project replies on do not themselves have types. Ambient definitions would be way easier. I might spike on that later this week starting with @ef4's types and adding types only for the API documented at https://ember-cli.com/api/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants