Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning in express-server test #9798

Open
locks opened this issue Feb 20, 2022 · 2 comments
Open

Fix warning in express-server test #9798

locks opened this issue Feb 20, 2022 · 2 comments
Labels
internal

Comments

@locks
Copy link
Contributor

locks commented Feb 20, 2022 

  express-server
    behaviour
(node:78554) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(Use `node --trace-warnings ...` to show where the warning was created)
@bertdeblock
Copy link
Contributor

bertdeblock commented Jun 27, 2022 •
edited

NODE_TLS_REJECT_UNAUTHORIZED is explicitly modified (and reset) for making the SSL test work, so I'm not sure if resolving this is possible without using an actual certificate?

@bertdeblock
Copy link
Contributor

It seems we have one in the repo at /tests/fixtures/ssl/server.crt. The flag was introduced here: #3550 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@locks @bertdeblock