Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/deprecate old deprecate utility? #9792

Closed
bertdeblock opened this issue Feb 20, 2022 · 2 comments · Fixed by #9937
Closed

Remove/deprecate old deprecate utility? #9792

bertdeblock opened this issue Feb 20, 2022 · 2 comments · Fixed by #9937
Assignees

Comments

@bertdeblock
Copy link
Contributor

A new one was added here: #9731.

Should we remove/deprecate the old one?

@rwjblue
Copy link
Member

rwjblue commented May 9, 2022

Does anyone outside of ember-cli use it? If not, lets just remove the older one; if they do we can update it to emit a deprecation itself (using the new infrastructure) and then have it call the new method (e.g. making it a wrapper around the newer utility).

@bertdeblock bertdeblock self-assigned this May 9, 2022
@bertdeblock
Copy link
Contributor Author

The only somewhat active addon that uses this is ember-cli-memory-leak-detector.
I made steveszc/ember-cli-memory-leak-detector#50 to resolve this.
We need #9899 and #9902 merged first as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants