Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-try scenario ember-default-with-jquery fails when ember-source is 4.0.0 #9701

Closed
SergeAstapov opened this issue Nov 26, 2021 · 3 comments

Comments

@SergeAstapov
Copy link
Contributor

Ember CLI addon blueprint has ember-try scenario ember-default-with-jquery that uses ember-source version of the addon's package.json.

If ember-source is 4.0.0 then scenario in CI fails with error:

=== Scenario: ember-default-with-jquery ========================================

Setting the `jquery-integration` optional feature flag to `true` was deprecated in Ember 3.x and removed in Ember 4.0.0. You must add the `@ember/optional-features` addon and set this feature to `false`.

For more information, see the deprecation guide: https://deprecations.emberjs.com/v3.x/#toc_optional-feature-jquery-integration


Result: false
---

Currently scenario is setup like so:

{
  name: 'ember-default-with-jquery',
  env: {
    EMBER_OPTIONAL_FEATURES: JSON.stringify({
      'jquery-integration': true,
    }),
  },
  npm: {
    devDependencies: {
      '@ember/jquery': '^1.1.0',
    },
  },
}

Thinking of options, this scenarios could set be renamed to ember-classic-with-jquery with 'ember-source': '~3.28.0'.

@SergeAstapov
Copy link
Contributor Author

For the context, actual error with Ember CLI 4.0.0 is

=== Scenario: ember-default-with-jquery ========================================

Setting the `jquery-integration` optional feature flag to `true` was deprecated in Ember 3.x and removed in Ember 4.0.0. You must add the `@ember/optional-features` addon and set this feature to `false`.

For more information, see the deprecation guide: https://deprecations.emberjs.com/v3.x/#toc_optional-feature-jquery-integration

Result: false

@BnitoBzh
Copy link

I'm agree with @SergeAstapov

Thinking of options, this scenarios could set be renamed to ember-classic-with-jquery with 'ember-source': '~3.28.0'.

@SergeAstapov
Copy link
Contributor Author

This was fixed by #9737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants