Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test's dummy app doesn't reexport /src in Module Unification adons #7666

Closed
cibernox opened this issue Mar 7, 2018 · 3 comments
Closed

Test's dummy app doesn't reexport /src in Module Unification adons #7666

cibernox opened this issue Mar 7, 2018 · 3 comments

Comments

@cibernox
Copy link
Contributor

cibernox commented Mar 7, 2018

The logic in #7490 has a hole.

When you generate an addon using the module unification layout but with the dummy app inside the test folder in "classic" mode, isModuleUnification check thinks the app is un MU layout, and doesn't reexport the contents of the addon's /src into /app automatically.

Reproduction: https://github.com/cibernox/my-mu-addon

@gossi
Copy link

gossi commented Oct 18, 2018

I think a more applicable approach for testing is what @mansona has done in https://github.com/mansona/testing-mu where you have in-repo apps that will serve as test apps. I think the blueprint for a mu addon should contain two apps by default: one classic, one mu-app to test the addon in both locations.

@ppcano
Copy link
Contributor

ppcano commented Mar 10, 2019

#8431 should fix this issue

@Turbo87
Copy link
Member

Turbo87 commented Dec 1, 2019

@Turbo87 Turbo87 closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants