-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor npm/yarn invocations #6790
Comments
Don't forget about our test helper which was intended to abstract away these differences: https://github.com/ember-cli/ember-cli/blob/master/tests/helpers/package-cache.js |
is there anyone working on this ? |
I’m looking into this, hopefully I can come up with something 🙋♂️ |
Hey team! I started working on it (progress at #9789) but got to the point where I would like to know/brainstorm exactly where do we want to take this. What is the ideal outcome of it? How much refactor/DRYness do we want in the code? How much abstraction do we want for install and etc.? Thanks in advance 🙇♂️ |
We currently have at least three areas of code where npm (and yarn) are used to install dependencies:
ember install
(andember new
,ember addon
andember init
) viaNpmInstallTask
classBlueprint.addPackagesToProject()
InstallBlueprintTask
class if the blueprint comes from npm (see Support npm packages asember new
blueprints #6789)We should try to refactor those code paths to reduce the duplication and use the same code underneath. In the same refactoring the
InstallBlueprintTask
class needs to be taught about yarn.see also #6784
The text was updated successfully, but these errors were encountered: