Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor npm/yarn invocations #6790

Open
Turbo87 opened this issue Feb 20, 2017 · 4 comments
Open

Refactor npm/yarn invocations #6790

Turbo87 opened this issue Feb 20, 2017 · 4 comments
Labels
Projects

Comments

@Turbo87
Copy link
Member

Turbo87 commented Feb 20, 2017

We currently have at least three areas of code where npm (and yarn) are used to install dependencies:

We should try to refactor those code paths to reduce the duplication and use the same code underneath. In the same refactoring the InstallBlueprintTask class needs to be taught about yarn.

see also #6784

@rwjblue
Copy link
Member

rwjblue commented Feb 20, 2017

Don't forget about our test helper which was intended to abstract away these differences: https://github.com/ember-cli/ember-cli/blob/master/tests/helpers/package-cache.js

@g13013
Copy link

g13013 commented May 5, 2017

is there anyone working on this ?

@locks locks added this to Needs Contributor in Triaging Mar 28, 2020
@locks locks moved this from Needs Contributor to INBOX in Triaging Jan 20, 2022
@locks locks moved this from INBOX to Needs Contributor in Triaging Jan 20, 2022
@gnclmorais
Copy link
Contributor

I’m looking into this, hopefully I can come up with something 🙋‍♂️

@gnclmorais
Copy link
Contributor

Hey team! I started working on it (progress at #9789) but got to the point where I would like to know/brainstorm exactly where do we want to take this. What is the ideal outcome of it? How much refactor/DRYness do we want in the code? How much abstraction do we want for install and etc.? Thanks in advance 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Triaging
Needs Contributor
Development

No branches or pull requests

5 participants