You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ember CLI blueprints run Prettier as part of the linters (ESLint, Stylelint). Prettier project explicitly recommends against doing so:
When searching for both Prettier and your linter on the Internet you’ll probably find more related projects. These are generally not recommended, but can be useful in certain circumstances.
First, we have plugins that let you run Prettier as if it was a linter rule:
These plugins were especially useful when Prettier was new. By running Prettier inside your linters, you didn’t have to set up any new infrastructure and you could re-use your editor integrations for the linters. But these days you can run prettier --check. and most editors have Prettier support.
The downsides of those plugins are:
You end up with a lot of red squiggly lines in your editor, which gets annoying. Prettier is supposed to make you forget about formatting – and not be in your face about it!
They are slower than running Prettier directly.
They’re yet one layer of indirection where things may break.
All those arguments seem to be valid for our use case as well. Additionally the integration of Prettier into linters has complicated the upgrade of Prettier, ESLint, Stylelint, Ember Template Lint iand related libraries n the past. For Prettier v3 many of those needed to be upgraded in a single PR due to limited sets of compatible versions.
Do we need a RFC to change how we integrate Prettier? Or do we consider it an implementation detail not requiring an RFC?
The text was updated successfully, but these errors were encountered:
Ember CLI blueprints run Prettier as part of the linters (ESLint, Stylelint). Prettier project explicitly recommends against doing so:
All those arguments seem to be valid for our use case as well. Additionally the integration of Prettier into linters has complicated the upgrade of Prettier, ESLint, Stylelint, Ember Template Lint iand related libraries n the past. For Prettier v3 many of those needed to be upgraded in a single PR due to limited sets of compatible versions.
Do we need a RFC to change how we integrate Prettier? Or do we consider it an implementation detail not requiring an RFC?
The text was updated successfully, but these errors were encountered: