Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember cli can not find default blueprint for scoped addons #10090

Closed
GendelfLugansk opened this issue Dec 2, 2022 · 0 comments · Fixed by #10091
Closed

Ember cli can not find default blueprint for scoped addons #10090

GendelfLugansk opened this issue Dec 2, 2022 · 0 comments · Fixed by #10091
Labels
bug

Comments

@GendelfLugansk
Copy link
Contributor

GendelfLugansk commented Dec 2, 2022 •
edited

Starting from version 4.3, ember cli can not find default blueprint for addon if addon is a scoped package (i.e. @scope/addon-name). If I install such addon, ember cli behaves like it does not have default blueprint. If I run ember g @scope/addon-name, it gives Unknown blueprint: @scope/addon-name. Unfortunately I can not provide a specific addon example to reproduce this issue, because it is published to private registry.

The cause of problem is line 1511 of lib/models/blueprint.js, which checks if blueprint name is a path (related PR). Scoped packages contain /, which is a path.sep.
GendelfLugansk added a commit to GendelfLugansk/ember-cli that referenced this issue Dec 2, 2022
@GendelfLugansk
Detect scoped packages
8d55506 
Fixes ember-cli#10090
@GendelfLugansk GendelfLugansk mentioned this issue Dec 2, 2022
Merged
@bertdeblock bertdeblock added the bug label Dec 2, 2022
bertdeblock pushed a commit to GendelfLugansk/ember-cli that referenced this issue Jan 27, 2023
@GendelfLugansk @bertdeblock
Fix looking up the default blueprint for scoped addons
2eebb4b 
Closes ember-cli#10090
bertdeblock pushed a commit to GendelfLugansk/ember-cli that referenced this issue Jan 27, 2023
@GendelfLugansk @bertdeblock
Fix looking up the default blueprint for scoped addons
ce4bacb 
Closes ember-cli#10090
bertdeblock pushed a commit to GendelfLugansk/ember-cli that referenced this issue Jan 30, 2023
@GendelfLugansk @bertdeblock
Fix looking up the default blueprint for scoped addons
61b8394 
Closes ember-cli#10090
bertdeblock pushed a commit to GendelfLugansk/ember-cli that referenced this issue Jan 31, 2023
@GendelfLugansk @bertdeblock
Fix looking up the default blueprint for scoped addons
56785b7 
Closes ember-cli#10090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Fix looking up the default blueprint for scoped addons GendelfLugansk/ember-cli
2 participants
@GendelfLugansk @bertdeblock