[ENHANCEMENT] Improve readability of asset-size printer and include Brotli sizes #10044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Oct 5, 2022
| @@ -5,46 +5,48 @@ const path = require('path'); | |||
| const walkSync = require('walk-sync'); | |||
| const workerpool = require('workerpool'); | |||
|
|
|||
| module.exports = class AssetPrinterSize { | |||
| module.exports = class AssetSizePrinter { | |||
There was a problem hiding this comment.
We use AssetSizePrinter everywhere else, and the filename is asset-size-printer as well.
| constructor(options) { | ||
| Object.assign(this, options); | ||
| this.outputPath = options.outputPath; |
There was a problem hiding this comment.
Makes it clearer what's expected / passed in.
| print() { | ||
| const { filesize } = require('filesize'); | ||
| let ui = this.ui; | ||
| async print() { |
There was a problem hiding this comment.
Switched to "async - await" for both print functions.
| let files = await this.makeAssetSizesObject(); | ||
|
|
||
| if (files.length !== 0) { | ||
| this.ui.writeLine(JSON.stringify({ files })); |
There was a problem hiding this comment.
The showGzipped property was removed, so we can print everything as is.
| @@ -0,0 +1,15 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
File was also renamed from gzipStats.js to gzip-stats.js for consistency.
|
This is fun.
|
bertdeblock
force-pushed
the
improve-asset-size-printer
branch
from
73a51af
to
bf2f41d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Human readable output:
JSON output:
brotliSizefield for each fileDownside: The addition of the Brotli size slows down the generation of asset sizes.
Closes #10023.