Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: Report compressed sizes with brotli at 11 #10023

Open
runspired opened this issue Sep 18, 2022 · 5 comments
Open

idea: Report compressed sizes with brotli at 11 #10023

runspired opened this issue Sep 18, 2022 · 5 comments

Comments

@runspired
Copy link
Contributor

Since the entire world now does this (right? right?!!?! if you don't you should) it would be awesome if the little print out after a production build or when using broccoli-concat-analyzer similarly did this.

@bertdeblock
Copy link
Contributor

bertdeblock commented Oct 4, 2022

@runspired Something like this?

Screenshot 2022-10-04 at 13 21 32

I quickly used brotli-size.
I'm not a compression expert, so I'm not sure how realistic the numbers here are.

I do think the table approach is better on the eyes than the current print out, but maybe that's subjective.

@runspired
Copy link
Contributor Author

Love it

@runspired
Copy link
Contributor Author

@bertdeblock any movement here?

@bertdeblock
Copy link
Contributor

@runspired We discussed this briefly during one of the previous CLI meetings. The only "downside" would be that this could slow down people's CI a bit, because the sizes are calculated by default after a build, and calculating the Brotli sizes takes a bit longer. For our projects, it probably wouldn't make that much of a difference, but I'm not sure I can make that assumption for others. Open to suggestions though! For example, maybe we could include the Brotli sizes when running the asset-sizes command, or maybe introduce a new --brotli flag for the asset-sizes command?

@runspired
Copy link
Contributor Author

runspired commented Feb 12, 2023

This is why I setup our builds in CI to run with --suppress-sizes hehe.

FWIW the better option is probably to not print at all unless the flag is passed. I'd also be interested in having the option to write the compressed output (since we're doing the work anyway).

The main thing is just that gzip sizes are meaningless to everyone at this point, seems odd to do the work for gzip for a number that isn't useful 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants