From 7f3b65ff9832916fbcbf30f1e259bd288acc376f Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Wed, 6 Oct 2021 17:49:59 -0400 Subject: [PATCH] Ensure `ember-classic` ember-try scenario uses Ember 3.x As we approach Ember 4.0.0, we need to help addons ensure that they only test ember-classic's set of optional features when running under 3.x. This updates the default ember-try config to hard code the `ember-classic` scenario to Ember 3.28 (the last 3.x Ember version). --- blueprints/addon/files/addon-config/ember-try.js | 5 +++++ tests/fixtures/addon/defaults/config/ember-try.js | 5 +++++ tests/fixtures/addon/yarn/config/ember-try.js | 3 +++ 3 files changed, 13 insertions(+) diff --git a/blueprints/addon/files/addon-config/ember-try.js b/blueprints/addon/files/addon-config/ember-try.js index 885aa9a250a..325f0f04442 100644 --- a/blueprints/addon/files/addon-config/ember-try.js +++ b/blueprints/addon/files/addon-config/ember-try.js @@ -62,6 +62,11 @@ module.exports = async function () { }, { name: 'ember-classic', + npm: { + devDependencies: { + 'ember-source': '~3.28.0', + }, + }, env: { EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'application-template-wrapper': true, diff --git a/tests/fixtures/addon/defaults/config/ember-try.js b/tests/fixtures/addon/defaults/config/ember-try.js index e6ef3ad925c..0b9f6d2e211 100644 --- a/tests/fixtures/addon/defaults/config/ember-try.js +++ b/tests/fixtures/addon/defaults/config/ember-try.js @@ -61,6 +61,11 @@ module.exports = async function () { }, { name: 'ember-classic', + npm: { + devDependencies: { + 'ember-source': '~3.28.0', + }, + }, env: { EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'application-template-wrapper': true, diff --git a/tests/fixtures/addon/yarn/config/ember-try.js b/tests/fixtures/addon/yarn/config/ember-try.js index d8bd6f97de3..c9d0dd79318 100644 --- a/tests/fixtures/addon/yarn/config/ember-try.js +++ b/tests/fixtures/addon/yarn/config/ember-try.js @@ -70,6 +70,9 @@ module.exports = async function () { }), }, npm: { + devDependencies: { + 'ember-source': '~3.28.0', + }, ember: { edition: 'classic', },