Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't include blueprint changes to ember-cli-update.json #1116

Open
kellyselden opened this issue Apr 13, 2021 · 1 comment
Open

doesn't include blueprint changes to ember-cli-update.json #1116

kellyselden opened this issue Apr 13, 2021 · 1 comment

Comments

@kellyselden
Copy link
Member

The latest ember-cli 3.26 includes a --embroider option in ember-cli-update.json. This does not come in when using ember-cli-update to do the update.

@rwjblue
Copy link
Member

rwjblue commented Apr 13, 2021

I wouldn't expect ember-cli-update when used for ember-cli@3.26.0 to add the flag to ember-cli-update.json. The default value in 3.26, was "classic" (aka non-Embroider) so the --embroider flag shouldn't be present.

However, when upgrading from 3.26 to 3.27 we definitely see the issue you are describing. Manual reproduction steps:

  1. npx ember-cli@3.26.0 new test-ember-cli-update
  2. npx ember-cli-update --package ember-cli --blueprint app --to 3.27.0-beta.1
  3. Check config/ember-cli-update.json and ember-cli-build.js

The ember-cli-build.js includes Embroider "things" but the config/ember-cli-update.json does not include --embroider flag.

I created https://github.com/rwjblue/___test-ember-cli-update-for-embroider to show what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants