fix: remove unneeded and confusing dep

[jelhan]

Please note the typo in dependency name.

Was added in df6ab75.

[Turbo87]

@jelhan I believe the reason for this dep was to ensure that the built dummy app is also minified when running ember build -prod. Did you check that this is still the case after your changes?

[jelhan]

To be honest I didn't checked before cause I didn't had in mind that this would affect build process regardless of typo. But if I didn't missed something it's still working:

$ git status
On branch fix-remove-unneeded-and-confusing-dep
Your branch is up to date with 'origin/fix-remove-unneeded-and-confusing-dep'.

nothing to commit, working tree clean

$ rm -rf node_modules/ tmp/ dist/

$ yarn
yarn install v1.12.3
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info fsevents@1.2.4: The platform "linux" is incompatible with this module.
info "fsevents@1.2.4" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning "ember-cli-qunit > ember-qunit > ember-cli-babel > babel-plugin-debug-macros@0.2.0" has unmet peer dependency "@babel/core@^7.0.0-beta.42".
[5/5] Building fresh packages...
Done in 2.87s.

$ ember build -prod
Could not start watchman
Visit https://ember-cli.com/user-guide/#watchman for more info.
WARNING: You have not included `ember-cli-shims` in your project's `bower.json` or `package.json`. This only works if you provide an alternative yourself and unset `app.vendorFiles['app-shims.js']`.
cleaning up...
Built project successfully. Stored in "dist/".
File sizes:
 - dist/assets/dummy.css: 0 B
 - dist/assets/dummy.js: 1.87 KB (768 B gzipped)
 - dist/assets/vendor.css: 0 B
 - dist/assets/vendor.js: 552.91 KB (152.19 KB gzipped)

$ cat dist/assets/dummy.js 
"use strict"
define("dummy/app",["exports","dummy/resolver","ember-load-initializers","dummy/config/environment"],function(e,t,n,r){Object.defineProperty(e,"__esModule",{value:!0})
var a=Ember.Application.extend({modulePrefix:r.default.modulePrefix,podModulePrefix:r.default.podModulePrefix,Resolver:t.default});(0,n.default)(a,r.default.modulePrefix),e.default=a}),define("dummy/initializers/container-debug-adapter",["exports","ember-resolver/resolvers/classic/container-debug-adapter"],function(e,t){Object.defineProperty(e,"__esModule",{value:!0}),e.default={name:"container-debug-adapter",initialize:function(){var e=arguments[1]||arguments[0]
e.register("container-debug-adapter:main",t.default),e.inject("container-debug-adapter:main","namespace","application:main")}}}),define("dummy/resolver",["exports","ember-resolver"],function(e,t){Object.defineProperty(e,"__esModule",{value:!0}),e.default=t.default}),define("dummy/router",["exports","dummy/config/environment"],function(e,t){Object.defineProperty(e,"__esModule",{value:!0})
var n=Ember.Router.extend({location:t.default.locationType,rootURL:t.default.rootURL})
n.map(function(){}),e.default=n}),define("dummy/templates/application",["exports"],function(e){Object.defineProperty(e,"__esModule",{value:!0}),e.default=Ember.HTMLBars.template({id:"FJRY0S8x",block:'{"symbols":[],"statements":[[7,"h2"],[11,"id","title"],[9],[0,"Welcome to Ember"],[10],[0,"\\n\\n"],[1,[21,"outlet"],false]],"hasEval":false}',meta:{moduleName:"dummy/templates/application.hbs"}})}),define("dummy/config/environment",[],function(){try{var e="dummy/config/environment",t=document.querySelector('meta[name="'+e+'"]').getAttribute("content"),n={default:JSON.parse(unescape(t))}
return Object.defineProperty(n,"__esModule",{value:!0}),n}catch(r){throw new Error('Could not read config from meta tag with name "'+e+'".')}}),runningTests||require("dummy/app").default.create({})

[Turbo87]

okay, great! happy to get rid of that strange workaround.