Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 6 #102

Merged
merged 1 commit into from Apr 9, 2019
Merged

Drop support for Node 6 #102

merged 1 commit into from Apr 9, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 6, 2019

#64 was not released yet, so we may as well combine it with dropping support for Node 6, which is EOL at the end of April.

@stefanpenner
Copy link
Contributor

I believe @rwjblue suggested for “core” or “bundled” libraries we should wait until jose 6 is actually EOL’d. As the node folks may push the timeline back, and that would create extra maintenance for us. Thoughts?

@Turbo87
Copy link
Member Author

Turbo87 commented Apr 6, 2019

@stefanpenner we discussed this on the call last Thursday and came to the conclusion that we only need to make sure that CLI master itself still works until Node 6 EOL. since this will be a major version bump I think this would be fine.

@Turbo87 Turbo87 merged commit 10199ef into ember-cli:master Apr 9, 2019
@Turbo87 Turbo87 deleted the node-6 branch April 9, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants