Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for production builds failing in 3.0.0.beta.2 #60

Closed
wants to merge 1 commit into from
Closed

Fix for production builds failing in 3.0.0.beta.2 #60

wants to merge 1 commit into from

Conversation

0xadada
Copy link

@0xadada 0xadada commented Feb 3, 2018 •
edited

Upstream package fixes a bug that is causing ember-cli builds to break in ember 3.0.0.beta.2.

Update dependencies fixes it.

Resolves ember-cli/ember-cli-terser#35
Fixes #61

@0xadada
Fix for production builds failing in 3.0.0.beta.2
ae34496 
Upstream package fixes a related problem. Update dependencies fixes it.

Related ember-cli/ember-cli-terser#35
@0xadada
Copy link
Author

0xadada commented Feb 3, 2018

@ef4 @stefanpenner @rwjblue

@0xadada 0xadada mentioned this pull request Feb 3, 2018
Closed
rwjblue
rwjblue reviewed Feb 4, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine, but doesn’t seem
required since the version bumped to is already allowed by the existing version range.

@0xadada
Copy link
Author

0xadada commented Feb 4, 2018

@rwjblue i first fixed it locally buy setting a resolution in my package.json to set uglify-js to the version later than the version that fixed the problem. Is there a way to help the package manager resolve uglify-es to a version 3.3.9 or greater without having consumers set a resolution?

@0xadada 0xadada closed this Feb 8, 2018
@0xadada 0xadada deleted the update-deps branch February 8, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@0xadada @rwjblue