Disable the modules API polyfill on Ember 3.27+ #683

pzuraq · 2021-03-16T22:30:35Z

Disables the modules API polyfill on the latest versions of Ember.

rwjblue · 2021-03-17T13:59:48Z

not ok 7 Chrome 89.0 - [48 ms] - tests/integration/components/test-inline-precompile: template literal proposal works
    ---
        actual: >
            null
        stack: >
            ReferenceError: _emberComponentTemplateOnly is not defined
                at Object._callee5$ (http://localhost:7357/assets/tests.js:508:19)
                at tryCatch (http://localhost:7357/assets/vendor.js:411:40)
                at Generator.invoke [as _invoke] (http://localhost:7357/assets/vendor.js:685:22)
                at Generator.prototype.<computed> [as next] (http://localhost:7357/assets/vendor.js:444:21)
                at asyncGeneratorStep (http://localhost:7357/assets/tests.js:348:105)
                at _next (http://localhost:7357/assets/tests.js:350:196)
                at http://localhost:7357/assets/tests.js:350:366
                at new Promise (<anonymous>)
                at Object.<anonymous> (http://localhost:7357/assets/tests.js:350:99)
                at Object.<anonymous> (http://localhost:7357/assets/tests.js:549:25)
        message: >
            Promise rejected during "template literal proposal works": _emberComponentTemplateOnly is not defined
        negative: >
            false
        browser log: |

pzuraq · 2021-03-17T14:13:12Z

Yeah, this PR is going to be dependent on

[BUGFIX] Use a unique identifier for each reference babel-plugin-htmlbars-inline-precompile#357
Do not transform imports to use the Ember global for ember-source@3.27 and higher emberjs/ember-cli-babel#387

The first one is a fix that directly impacts the behavior of this addon, the second one is required in order to properly test this addon with the intended behavior

Disables the modules API polyfill on the latest versions of Ember.

rwjblue · 2021-03-17T17:10:25Z

Rebased to pull in the babel-plugin-htmlbars-inline-precompile updates .

…:ember-cli/ember-cli-htmlbars into disable-modules-api-polyfill-with-latest

rwjblue · 2021-03-17T21:37:03Z

lib/template-compiler-plugin.js

@@ -24,7 +24,7 @@ function rethrowBuildError(error) {
 }

 class TemplateCompiler extends Filter {
-  constructor(inputTree, _options) {
+  constructor(inputTree, _options, requiresModuleApiPolyfill) {


Should probably default to true here. Otherwise, this is a breaking change.

rwjblue · 2021-03-17T21:40:10Z

lib/colocated-babel-plugin.js

+        state._colocationEnsureImport = (exportName, moduleName) => {
+          let addedImports = (allAddedImports[moduleName] = allAddedImports[moduleName] || {});
+
+          if (addedImports[exportName]) return addedImports[exportName];


Doesn't this suffer from the same problem that ember-cli/babel-plugin-htmlbars-inline-precompile#357 fixed?

Shouldn't this return a new identifier each time?

rwjblue · 2021-03-17T21:40:22Z

lib/colocated-babel-plugin.js

+            path.unshiftContainer('body', newImport);
+          }
+
+          return addedImports[exportName];


Doesn't this suffer from the same problem that ember-cli/babel-plugin-htmlbars-inline-precompile#357 fixed?

rwjblue · 2021-03-17T21:44:16Z

node-tests/template_compiler_test.js

+      })
+    );
+
+    it('invokes AST plugins', async function () {


thanks for using async/await here, I just haven't had a chance to clean these other co.wrap's up yet

rwjblue · 2021-03-17T21:51:47Z

node-tests/template_compiler_test.js

-    assert.strictEqual(outputString, expected);
-    assert.ok(outputString.includes('Huzzah!'));
-  });
+      let tree = new TemplateCompiler(input.path(), htmlbarsOptions, true);


FWIW, adding true here is the thing I was referring to (as a breaking change). If you do require('ember-cli-htmlbars') the thing you get is the template compiler broccoli-plugin (for better or worse) which makes the constructor at least intimate API (but probably public).

ef4 · 2021-03-28T20:40:24Z

lib/ember-addon-main.js

@@ -169,6 +170,9 @@ module.exports = {

    let isProduction = process.env.EMBER_ENV === 'production';

+    let checker = new VersionChecker(this.parent).for('ember-source', 'npm');


I suspect this is broken in second-level or deeper addons. They're looking for ember-source in their parent only, but should be looking at the top level project. Same kind of bug as emberjs/ember-cli-babel#396

pzuraq force-pushed the disable-modules-api-polyfill-with-latest branch from 2c27d0f to 4d205a4 Compare March 16, 2021 22:44

Disable the modules API polyfill on latest Ember

45bdb10

Disables the modules API polyfill on the latest versions of Ember.

pzuraq force-pushed the disable-modules-api-polyfill-with-latest branch from bfafe95 to 45bdb10 Compare March 16, 2021 23:33

wip

1d080da

Disable the modules API polyfill on latest Ember

26d9fdc

Disables the modules API polyfill on the latest versions of Ember.

rwjblue force-pushed the disable-modules-api-polyfill-with-latest branch from 45bdb10 to 26d9fdc Compare March 17, 2021 17:10

Merge branch 'disable-modules-api-polyfill-with-latest' of github.com…

b66e57e

…:ember-cli/ember-cli-htmlbars into disable-modules-api-polyfill-with-latest

pzuraq force-pushed the disable-modules-api-polyfill-with-latest branch from 3871565 to fadc36c Compare March 17, 2021 21:20

patocallaghan mentioned this pull request Mar 17, 2021

Pass useEmberModule option to plugins #682

Closed

rwjblue requested changes Mar 17, 2021

View reviewed changes

rwjblue reviewed Mar 17, 2021

View reviewed changes

bump ember-cli-babel

3697751

pzuraq force-pushed the disable-modules-api-polyfill-with-latest branch from fadc36c to 3697751 Compare March 17, 2021 21:52

rwjblue approved these changes Mar 18, 2021

View reviewed changes

rwjblue merged commit d92706b into master Mar 18, 2021

delete-merged-branch bot deleted the disable-modules-api-polyfill-with-latest branch March 18, 2021 00:30

rwjblue added the enhancement label Mar 18, 2021

rwjblue changed the title ~~Disable the modules API polyfill on latest Ember~~ Disable the modules API polyfill on Ember 3.27+ Mar 18, 2021

ef4 reviewed Mar 28, 2021

View reviewed changes

pzuraq mentioned this pull request Apr 26, 2021

Tracking remaining usage of the Ember global emberjs/ember.js#19506

Closed

3 tasks

sandydoo mentioned this pull request Apr 27, 2021

Webpack is using the Ember global in compiled templates embroider-build/embroider#781

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable the modules API polyfill on Ember 3.27+ #683

Disable the modules API polyfill on Ember 3.27+ #683

pzuraq commented Mar 16, 2021

rwjblue commented Mar 17, 2021

pzuraq commented Mar 17, 2021

rwjblue commented Mar 17, 2021

rwjblue Mar 17, 2021

rwjblue Mar 17, 2021

rwjblue Mar 17, 2021

rwjblue Mar 17, 2021

rwjblue Mar 17, 2021

ef4 Mar 28, 2021 •

edited

		@@ -169,6 +170,9 @@ module.exports = {

		let isProduction = process.env.EMBER_ENV === 'production';

		let checker = new VersionChecker(this.parent).for('ember-source', 'npm');

Disable the modules API polyfill on Ember 3.27+ #683

Disable the modules API polyfill on Ember 3.27+ #683

Conversation

pzuraq commented Mar 16, 2021

rwjblue commented Mar 17, 2021

pzuraq commented Mar 17, 2021

rwjblue commented Mar 17, 2021

rwjblue Mar 17, 2021

Choose a reason for hiding this comment

rwjblue Mar 17, 2021

Choose a reason for hiding this comment

rwjblue Mar 17, 2021

Choose a reason for hiding this comment

rwjblue Mar 17, 2021

Choose a reason for hiding this comment

rwjblue Mar 17, 2021

Choose a reason for hiding this comment

ef4 Mar 28, 2021 • edited

Choose a reason for hiding this comment

ef4 Mar 28, 2021 •

edited