Skip to content

Remove setEdition requirement for colocation. #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 11, 2019

Changes the _cachedShouldColocateTemplates logic to require the following:

  • ember-cli-babel >= 7.11.0
  • ember-cli >= 3.12.0-beta.2
  • ember-source >= 3.13.0

In the future, when we have a setComponentTemplate and templateOnly polyfill we can update the ember-source requirement to also check for the polyfill.

Changes the `_cachedShouldColocateTemplates` logic to require the
following:

* `ember-cli-babel` >= 7.11.0
* `ember-cli` >= 3.12.0-beta.2
* `ember-source` >= 3.13.0

In the future, when we have a `setComponentTemplate` and `templateOnly`
polyfill we can update the `ember-source` requirement to also check for
the polyfill.
@rwjblue
Copy link
Member Author

rwjblue commented Dec 11, 2019

I'm largely waiting to land this until I've gotten some feedback on the ember-cli-htmlbars@4.1.0 release (which introduced the patch based build tweaks that enable this PR). I'd love folks to chime in here that they have tested 4.1.0 in apps that use octane today...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant