Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate eslint-friendly-formatter #67

Open
elwayman02 opened this issue Jun 8, 2016 · 3 comments
Open

Integrate eslint-friendly-formatter #67

elwayman02 opened this issue Jun 8, 2016 · 3 comments

Comments

@elwayman02
Copy link
Contributor

It would be great to automatically run eslint using this package as a formatter, so that people can integrate their terminal with editors to easily click into a file when they see an error.

https://github.com/royriojas/eslint-friendly-formatter

All we'd need to do is update the eslint command to add --format 'node_modules/eslint-friendly-formatter' (accounting, of course, for OS differences & npm2 vs npm3).

@elwayman02 elwayman02 reopened this Jun 8, 2016
@alexlafroscia
Copy link
Collaborator

I can see the iTerm support being useful, but wouldn't editor integration need to be done through whatever plugin is actually running the linter? For example, in Neovim I can configure Neomake to run ESLint with different arguments... You want to modify the output of ember test?

@alexlafroscia
Copy link
Collaborator

So, I got a basic version of this working and it's really simple. The problems right now are that

  1. Formatters provided with a relative path to node_modules don't seem to be discovered correctly
  2. The output in the test cases isn't affected; only the output before the tests cases are

screen shot 2016-07-01 at 11 35 08 pm

It would definitely be helpful to get a better sense for what you're hoping integration with custom formatters will achieve to know if that's enough, or if you're looking for something else.

@simonc
Copy link

simonc commented Jun 1, 2018

Hi there.

I don't know if adding a new dependency for the purpose of terminal-click is a good idea. ESLint has a unix formatter that would fit the need in terms of filenames clickability.

Now I understand that the unix formatter output is not very sexy ^^

Wouldn't adding an option to allow formatter selection be enough to begin with?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants