Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should work without a tests folder? #249

Open
Bouke opened this issue Oct 9, 2018 · 4 comments
Open

Should work without a tests folder? #249

Bouke opened this issue Oct 9, 2018 · 4 comments

Comments

@Bouke
Copy link

Bouke commented Oct 9, 2018

My ember app doesn't have tests, hence I removed the test folder. However when this module is added, the following error message will be printed: broccoli-persistent-filter:EslintValidationFilter: Expected Broccoli node, got null for inputNodes[0].

Repro:

ember new --yarn notests
cd notests
rm -rf tests
yarn build

Gives the following output:

yarn run v1.10.1
$ ember build
⠋ Buildingbroccoli-persistent-filter:EslintValidationFilter: Expected Broccoli node, got null for inputNodes[0]


Stack Trace and Error Report: /var/folders/z3/r5mpk9zx2x9g2ldj8jsxbgw80000gn/T/error.dump.83017b5fd1c6e7535e57ba952c5b8f03.log
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@Turbo87
Copy link
Member

Turbo87 commented Oct 13, 2018

I'm not sure that this is the right place for this issue. The error pops up in the EslintValidationFilter class, but only because it is being called incorrectly by the build pipeline. Since you linked ember-cli/ember-cli#8094 I assume you use the regular Ember.js build pipeline, so I'd rather open the issue on the ember-cli repo again, and close this one here.

@alexborovkov
Copy link

@Bouke I have the same issue. Have you found how to fix it?

@Bouke
Copy link
Author

Bouke commented Nov 18, 2019

I simply created the test folder so it doesn't trigger this bug anymore. :shipit:

@yandiro
Copy link

yandiro commented Jun 21, 2020

I still get this. Even with the tests folder created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants