Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow initial build #23

Open
mmahalwy opened this issue Sep 2, 2015 · 7 comments
Open

Slow initial build #23

mmahalwy opened this issue Sep 2, 2015 · 7 comments

Comments

@mmahalwy
Copy link

mmahalwy commented Sep 2, 2015

The build is really really slow since we included this:

Slowest Trees                                 | Total
----------------------------------------------+---------------------
EslintValidationFilter                        | 31237ms
EslintValidationFilter                        | 11729ms
@jonathanKingston
Copy link
Member

This is the product of many things at play, some are solvable some are not.

  • Caching filter can be used
  • Closer integration with Ember to not require JSHint

ESLint is however slower than JSHint, the advantages are flexibility.

My time is fairly limited at the moment and although this is a crappy response, it is a reality.

I'm happy to accept pull requests until I get some more time to resolve.

@mmahalwy
Copy link
Author

mmahalwy commented Sep 2, 2015

Hey @jonathanKingston sounds good - perhaps it'd be useful to have the initial build not run eslint but rebuilds do? Perhaps you can guide me really quickly where the API for rebuilds is and I will go at it :)

@hjbuchanan
Copy link

Hi, I was wondering if there had been any work done on this? We are running into similar issues with slow build times. We want to be able to run eslint in our test suite but not on the initial build of the app. Is there anyway to disable linting on the build?

@Turbo87
Copy link
Member

Turbo87 commented Oct 11, 2016

@hjbuchanan unfortunately that is currently not possible 😕

@hjbuchanan
Copy link

@Turbo87 thanks for the quick comment back--would you all be willing to accept a PR that made those changes?

@Turbo87
Copy link
Member

Turbo87 commented Oct 11, 2016

@hjbuchanan sure, we are always happy to review and merge PRs! what specific changes are we talking about though? only running ESLint on demand when running tests is unfortunately impossible or at least very difficult to implement.

@kmiyashiro
Copy link

There is an option called hinting that this plugin should respect. If it is false, it should not run. You can toggle this in your ember-cli-build.js by detecting the environment.

ex:

module.exports = function(defaults) {
  var app = new EmberApp(defaults, {
    hinting: EmberApp.env() === 'test',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants