Fix using "group" option without a "testGenerator" #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
requested changes
Oct 24, 2017
| @@ -43,7 +43,7 @@ module.exports = { | |||
|
|
|||
| return ESLint.create(tree, { | |||
| testGenerator: this.options.testGenerator || this._testGenerator, | |||
| group: (this.options.group !== false) ? type : undefined, | |||
| group: (this.options.testGenerator && this.options.group !== false) ? type : undefined, | |||
There was a problem hiding this comment.
this does not work if the test generator is detected automatically by this._testGenerator.
I guess the logic should be:
use group: type if:
group: truewas explicitly specified- a
testGeneratorwas specified or automatically detected that supportsgroup(will have to build something likeESLint.supportsGrouping(testGeneratorName)into https://github.com/ember-cli/broccoli-lint-eslint)
and otherwise set the group option to undefined
|
closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #213, by preventing to set
groupoption totrueif thetestGeneratoroption is not set.