Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the options #67

Open
danielo515 opened this issue Apr 29, 2018 · 4 comments
Open

Document the options #67

danielo515 opened this issue Apr 29, 2018 · 4 comments

Comments

@danielo515
Copy link

Which options are supported ? There is no documentation about that.
I want to pass an option to uglify to not remove comments. How can I do it ?

Regards

@danielo515
Copy link
Author

Ok, I found the solution, just use

tree = uglify(tree, { uglify: { output: { comments: 'some' } }});

However I come to this conclusion by reading the package.json dependencies and going to the uglify repo and reading the documentation, praising them to be compatible.

I still think you should at least that an external documentation should be checked.

Regards

@Turbo87
Copy link
Member

Turbo87 commented May 25, 2018

@danielo515 did you see https://github.com/ember-cli/broccoli-uglify-sourcemap#usage? is that not enough? we're always open to suggestions and PRs to improve the documentation :)

@danielo515
Copy link
Author

Hello @Turbo87
Sadly not, it is not enough since it does not explains all the options neither points to a place to check all the options available.

@Turbo87
Copy link
Member

Turbo87 commented Jun 1, 2018

it's all the options that uglifyjs itself accepts, since that options hash is essentially just forwarded. I thought that would be clear from the code snippet, but apparently not. Can you open a PR explaining that and adding a link to the uglifyjs (or now terser) documentation that explains what options are available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants