Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ember-bootstrap blueprints #2090

Open
SanderKnauff opened this issue Feb 10, 2024 · 2 comments
Open

Deprecate ember-bootstrap blueprints #2090

SanderKnauff opened this issue Feb 10, 2024 · 2 comments
Labels

Comments

@SanderKnauff
Copy link
Contributor

Since V2 addons do not support blueprints, the ember-bootstrap blueprint should be deprecated before the conversion.
The documentation contains instructions that use the blueprints, so these need to be updated to instead describe the manual steps required for configuring the addon.

@jelhan
Copy link
Contributor

jelhan commented Feb 11, 2024

How would deprecating the blueprints look like? If consumer installs ember-bootstrap using ember install, the blueprints are executed automatically. I fear we can only remove them without deprecating upfront.

Also deprecating may not be worse it. Typically the blueprints are only run once on installation. So likely a consumer sees the deprecation warning only once (if ever).

I wonder if we should consider dropping the blueprints a breaking change. It would not affect any app, which are using ember-bootstrap already. It would only affect projects who have setup some automation for generating new Ember apps, which rely on our blueprints being executed. But I feel it is unlikely that this exists in practice. And if it exists, I wouldn't consider it as being official support.

Long story short: I would be fine with removing the blueprints in the next minor release.

@SanderKnauff
Copy link
Contributor Author

SanderKnauff commented Feb 15, 2024

The documentation does mention an automated way to change the project configuration from Bs4/Bs5 using ember-generate [1].
I'm not sure how actively used it is, but that would be a possible place to add a deprecation notice.
That said, I don't mind removing it if that is preferred. That also means that we can remove the node tests that are currently living in the addon project.

[1] https://www.ember-bootstrap.com/getting-started/setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants