You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rsvp dependency should not be needed anymore. It was primarily a polyfill for native Promise. All modern browsers support native Promise these days. We can simplify our code base and prepare for planned deprecation by removing the dependency.
@NullVoxPopuli started the work in #1875 but doesn't have the time to finish it.
RSVP is not used at many places. GitHub code search lists 11 places.
Main priority should be on code shipped to end user. This affects 3 places:
transitionEnd utility function (addon/utils/transition-end.js)
<BsForm> component (addon/components/bs-form.js)
Blueprints (blueprints/ember-bootstrap/index.js)
Having rsvp as a dependency rather than a dev dependency.
The other 7 places affects only code, which is not shipped to consumers:
docs app (2 files)
tests (4 files)
node tests (1 file)
In most cases the transition should be fairly simple. RSVP.Promise, RSVP.reject, and RSVP.resolve can be replaced with their native equivalents. Only RSVP.defer does not have a native equivalent. But it could be replaced by an utility function, which I sketched here: #1875 (comment)
The text was updated successfully, but these errors were encountered:
The
rsvp
dependency should not be needed anymore. It was primarily a polyfill for nativePromise
. All modern browsers support nativePromise
these days. We can simplify our code base and prepare for planned deprecation by removing the dependency.@NullVoxPopuli started the work in #1875 but doesn't have the time to finish it.
RSVP is not used at many places. GitHub code search lists 11 places.
Main priority should be on code shipped to end user. This affects 3 places:
transitionEnd
utility function (addon/utils/transition-end.js
)<BsForm>
component (addon/components/bs-form.js
)blueprints/ember-bootstrap/index.js
)rsvp
as a dependency rather than a dev dependency.The other 7 places affects only code, which is not shipped to consumers:
In most cases the transition should be fairly simple.
RSVP.Promise
,RSVP.reject
, andRSVP.resolve
can be replaced with their native equivalents. OnlyRSVP.defer
does not have a native equivalent. But it could be replaced by an utility function, which I sketched here: #1875 (comment)The text was updated successfully, but these errors were encountered: