Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yielded link-to component from <BsNav> #1707

Open
jelhan opened this issue Nov 18, 2021 · 2 comments
Open

Remove yielded link-to component from <BsNav> #1707

jelhan opened this issue Nov 18, 2021 · 2 comments
Labels

Comments

@jelhan
Copy link
Contributor

jelhan commented Nov 18, 2021

Some time ago we renamed the yielded property of <BsNav> from link-to to linkTo. But we kept the original one to not introduce a breaking change: https://github.com/kaliber5/ember-bootstrap/blob/31d43678ac0fa52d5bd36e3d8e570d1b9b46d0b4/addon/components/bs-nav.hbs#L5-L6

We may want to remove it as part of next major.

@simonihmig
Copy link
Contributor

Do you think it's worth it? Or should we just keep it for dev convenience. After all, this requires some changes for users (we could help via our codemod - but do we have time to work on this?), and the maintenance benefit seem low (not much significant tech debt by keeping this?).

@jelhan
Copy link
Contributor Author

jelhan commented Jan 19, 2023

Wondering if we should revisit the decision for v6. I feel the arguments are still the same. But after such a long time most consumers may have refactored away from it anyways?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants