Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form submit catch error tests failing for Embroider #1682

Open
simonihmig opened this issue Nov 6, 2021 · 0 comments
Open

Form submit catch error tests failing for Embroider #1682

simonihmig opened this issue Nov 6, 2021 · 0 comments
Labels

Comments

@simonihmig
Copy link
Contributor

simonihmig commented Nov 6, 2021

Even without any explicit dependency update, since some days these two tests added in #1581 are failing for Embroider scenarios. See this scheduled run which is failing, compared to the scheduled run a week earlier which is passing.

In those tests the callback to setupOnerror() (which delegates to Ember.onError) is indeed not called, no idea why. The scenario adds the embroider dependencies and webpack, so my assumption is some recent updates to those dependency were causing this. I tried to track this down by pining embroider or webpack dependencies down to earlier versions, but that did not succeed. Those tests are still failing, so maybe related to some transitive dependencies?

cc @jelhan @ef4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants