Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance marks incorrectly recorded for Evented trigger method #34

Open
mwhitworth opened this issue May 16, 2020 · 0 comments · May be fixed by #38
Open

Performance marks incorrectly recorded for Evented trigger method #34

mwhitworth opened this issue May 16, 2020 · 0 comments · May be fixed by #38

Comments

@mwhitworth
Copy link

After ae8e47d Without specifying any options relating to ember-perf-timeline - overriding the Evented trigger method will call the TriggerMixin to be called for all trigger calls in Evented in all cases. (This causes a large jump in memory usage for a complex application)

Perhaps the TriggerMixin should be only be registered for these Ember objects when any one of the ember-perf-timeline options are enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant