Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternatives to Overriding clearMeasures and clearMarks #24

Open
kanalveli-ramachandran opened this issue Mar 12, 2019 · 1 comment
Open

Comments

@kanalveli-ramachandran
Copy link

Consider the use case where you create render measures for every route and flush them after sending them to an analytics tool of your choice. This behaviour is impacted when we override clearMeasures and clearMarks.

Alternatives will be to add a configuration to let the consuming app decide on this implementation.
Or conditionally prevent certain marks or measures from being cleared based on the component pattern.

@stefanpenner
Copy link
Collaborator

Sounds very reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants