Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurations to enable perf-timeline in development without queryParams #23

Open
kanalveli-ramachandran opened this issue Mar 12, 2019 · 3 comments

Comments

@kanalveli-ramachandran
Copy link

During development, adding the _ember-perf-timeline queryParam to every route we profile is a bit cumbersome. It will be useful to add a configuration to always enable component measures in development environment.

I'd like to contribute towards this if it sounds good.

@ghost
Copy link

ghost commented Apr 2, 2019

Totally agree. I also could not dynamically specify the _ember-perf-timeline query parameter when invoking transitionTo methods. Probably because I didn't configure the routes 😄

This relates somewhat to #19. Perhaps a configuration / some design could cover both?

@danDanV1
Copy link

@xg-wangs config would be helpful here. I am working on profiling route transitions with animations, and ember will drop the _ember-perf-timeline query param from the URL on the transition unless I sprinkle it into all our controllers.

@xg-wang
Copy link
Contributor

xg-wang commented Feb 15, 2020

@edeis53 the added section in readme in the merged PR has configuration https://github.com/ember-best-practices/ember-perf-timeline/pull/31/files#diff-04c6e90faac2675aa89e2176d2eec7d8
And I think transition dropping QP wouldn't matter because the setup by reading QP is done only once in initializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants